[Featured] Consider AutoServiceScopes in autocomplete handler executions
#3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
My disposal was previously flawed. I fixed it now, the code takes a bit to understand but is methodically correct and 1:1 mimics previous behavior. |
Misha-133
approved these changes
Mar 1, 2025
This was referenced Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for considering
InteractionService._autoServiceScopein autocomplete handlers, creating a new scope for theIServiceProviderpassed toGenerateSuggestionsAsync(). The code follows the same concept already applied for command executions here.Changes
AutocompleteHandler.ExecuteAsyncmethod