Fixed type reader/converter parsing exception #3084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misha-133
approved these changes
Mar 28, 2025
This was referenced Aug 4, 2025
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default value reader/converter only catch for
InvalidCastExceptions but not for FormatExceptions which will be thrown if Convert.ChangeType can't parse the provided value.This causes
InteractionService.ExecuteAsyncto return anExecuteResultinstead of aTypeConverterResultwhen invalid values were provided.Changes
Catches also
FormatExceptions on every use ofConvert.ChangeType.Related Issues
N/A