Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Update Headers #180

Merged
merged 10 commits into from
Nov 1, 2024
Merged

[feat] Update Headers #180

merged 10 commits into from
Nov 1, 2024

Conversation

amyjchen
Copy link
Collaborator

@amyjchen amyjchen commented Oct 31, 2024

Changes Made:

  • updates headers on read pages
  • makes tweaks to text alignment on profile page
Before After After (narrow screen)
Screenshot 2024-10-31 at 14 52 08 Screenshot 2024-10-31 at 14 51 36 no change
Screenshot 2024-10-31 at 14 53 21 Screenshot 2024-10-31 at 14 52 46 Screenshot 2024-10-31 at 14 56 31
Screenshot 2024-10-31 at 14 53 26 Screenshot 2024-10-31 at 14 52 54 Screenshot 2024-10-31 at 14 56 39
Screenshot 2024-10-31 at 14 53 29 Screenshot 2024-10-31 at 14 53 00 Screenshot 2024-10-31 at 14 56 45
Screenshot 2024-10-31 at 14 53 35 Screenshot 2024-10-31 at 14 53 09 no change
Screenshot 2024-10-31 at 15 06 49 Screenshot 2024-10-31 at 15 06 34 no change

@amyjchen amyjchen changed the title [feat] updated headers on read pages [feat] Update Headers Oct 31, 2024
@amyjchen amyjchen marked this pull request as ready for review October 31, 2024 21:59
@somethingnew2-0
Copy link
Collaborator

image

Can the group icon on the right be vertically centered?

@amyjchen
Copy link
Collaborator Author

amyjchen commented Nov 1, 2024

image

Can the group icon on the right be vertically centered?

yup, just updated!

Screenshot 2024-11-01 at 10 16 56

</Box>
) : null}
</Stack>
<Divider />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the current user isn't an Access Admin (member of App-Access-Owners) or isn't an App Owner (owner of App Owners group), they don't see anything below this divider. Is there some way we could remove it for that case?

Screenshot 2024-11-01 at 1 42 25 PM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh good point. I'll update there and in tags

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@amyjchen amyjchen merged commit be55f39 into 2024-hackweek Nov 1, 2024
6 checks passed
@amyjchen amyjchen deleted the feat/new-headers branch November 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants