feat(conditional-access): changed this to work with tags as well as group names #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. |
somethingnew2-0
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Makes sense as follow-up to #37, LGTM!
Let me know if you're ready to merge this PR.
|
Going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this is to add the ability to use Tags as well as groups. I know people will customize this but I thought this might give them a better base if they don't have complex use cases.
Auto-Approveis used. This means you don't have to set any environment variables if you don't want.Verified this works in my deployment. Please let me know if a test is required for plugins