Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details of message_reference object #2053

Merged
merged 10 commits into from
Apr 6, 2021
Merged

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Sep 8, 2020

No description provided.

@advaith1 advaith1 mentioned this pull request Oct 2, 2020
@advaith1 advaith1 marked this pull request as draft October 3, 2020 00:20
@advaith1
Copy link
Contributor Author

advaith1 commented Oct 7, 2020

documented that this is returned on replies; pending on #2118

docs/resources/Channel.md Outdated Show resolved Hide resolved
Copy link
Contributor

@msciotti msciotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the nit and whatever merge conflicts

mavolin added a commit to mavolin/arikawa that referenced this pull request Nov 3, 2020
Add addtiontional type information to MessageReference as found in discord/discord-api-docs#2053
diamondburned pushed a commit to diamondburned/arikawa that referenced this pull request Nov 3, 2020
Add addtiontional type information to MessageReference as found in discord/discord-api-docs#2053
@davfsa
Copy link
Contributor

davfsa commented Nov 17, 2020

@msciotti Since #2118 already got merged, could we merge this one too?

@advaith1 advaith1 marked this pull request as ready for review November 17, 2020 08:02
@advaith1 advaith1 marked this pull request as draft April 3, 2021 04:12
@advaith1 advaith1 marked this pull request as ready for review April 3, 2021 04:16
@night night merged commit af53098 into discord:master Apr 6, 2021
@advaith1 advaith1 deleted the reference branch April 6, 2021 02:24
itohatweb added a commit to discordeno/discordeno that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants