Skip to content

Document role icons #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Document role icons #3815

wants to merge 19 commits into from

Conversation

@Lulalaby
Copy link
Contributor

No description provided.

Lulalaby
Lulalaby commented Sep 12, 2021
View reviewed changes
@Lulalaby
Copy link
Contributor Author

@msciotti I think you want to add in experiment

@Lulalaby Lulalaby mentioned this pull request Sep 12, 2021
Closed
@iShibi iShibi mentioned this pull request Sep 13, 2021
Merged
@ImRodry
Copy link
Contributor

ImRodry commented Sep 13, 2021

Do you have an example of a cdn url to a role icon?

@Jupith
Copy link
Contributor

Jupith commented Sep 13, 2021

Do you have an example of a cdn url to a role icon?

https://cdn.discordapp.com/role-icons/860078619648851978/cf3ced8600b777c9486c6d8d84fb4327.png?size=16

NurMarvin
NurMarvin suggested changes Sep 13, 2021
View reviewed changes
@l7ssha l7ssha mentioned this pull request Sep 13, 2021
Closed
jkcailteux
jkcailteux reviewed Sep 13, 2021
View reviewed changes
@typpo typpo added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Sep 14, 2021
@sebm253 sebm253 mentioned this pull request Sep 15, 2021
Merged
6 tasks
@Grace-codes Grace-codes mentioned this pull request Sep 16, 2021
Closed
AnotherZane
AnotherZane suggested changes Sep 17, 2021
View reviewed changes
@noaione noaione mentioned this pull request Sep 17, 2021
Merged
6 tasks
ImRodry
ImRodry reviewed Sep 18, 2021
View reviewed changes
Copy link
Contributor

@ImRodry ImRodry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Role icons have rolled out slightly and I found some things that should probably be changed

A5rocks
A5rocks reviewed Sep 19, 2021
View reviewed changes
@AnotherZane
Copy link
Contributor

Changing the role icon also adds an audit log, the key being used for it is icon_hash which is currently used for guild icon changes so would be great if you could document that as well.

@Lulalaby
Copy link
Contributor Author

I'll document it later.

But for now let's enjoy the weekend :)

@Lulalaby Lulalaby requested a review from jkcailteux September 20, 2021 14:34
@Lulalaby
Copy link
Contributor Author

I totally confused myself, that's why I marked all as resolved. So if anyone got suggestions, please redo :(

AnotherZane
AnotherZane suggested changes Sep 20, 2021
View reviewed changes
@Lulalaby @AnotherZane
Apply suggestions from code review
28a0cef 
Co-authored-by: Zane Pereira <zanedpereira2@gmail.com>
@Lulalaby
Copy link
Contributor Author

@AnotherZane Thanks!

@jkcailteux
Copy link
Contributor

Changing the role icon also adds an audit log, the key being used for it is icon_hash which is currently used for guild icon changes so would be great if you could document that as well.

There's another field in audit logs unicode_emoji as well.

@Lulalaby
Copy link
Contributor Author

Changing the role icon also adds an audit log, the key being used for it is icon_hash which is currently used for guild icon changes so would be great if you could document that as well.

There's another field in audit logs unicode_emoji as well.

Gimme a sec

@Lulalaby @AnotherZane
Fix formatting
9711a97 

Co-authored-by: Zane Pereira <zanedpereira2@gmail.com>
jkcailteux
jkcailteux reviewed Sep 20, 2021
View reviewed changes
@Lulalaby Lulalaby requested a review from jkcailteux September 20, 2021 17:03
@Lulalaby
Copy link
Contributor Author

Lulalaby commented Sep 20, 2021 •
edited
Loading

Tbh, did I missed anything?

@Lulalaby Lulalaby closed this Sep 21, 2021
@Lulalaby Lulalaby deleted the feature/role-icons branch September 21, 2021 20:12
@Lulalaby
Copy link
Contributor Author

I'm sorry guys, my git crashed all, I'm gonna recreate the prs

@ImRodry
Copy link
Contributor

ImRodry commented Sep 21, 2021

Can’t you recreate the branch?

@Lulalaby
Copy link
Contributor Author

I'm on it

@Lulalaby
Copy link
Contributor Author

Follow up: #3847

@Yomanz Yomanz mentioned this pull request Oct 11, 2021
Merged
@night night removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@advaith1 advaith1 advaith1 left review comments

@jkcailteux jkcailteux Awaiting requested review from jkcailteux

+6 more reviewers

@MinnDevelopment MinnDevelopment MinnDevelopment left review comments

@ImRodry ImRodry ImRodry left review comments

@A5rocks A5rocks A5rocks left review comments

@Jupith Jupith Jupith left review comments

@NurMarvin NurMarvin NurMarvin requested changes

@AnotherZane AnotherZane AnotherZane requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.