Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back nonce #5078

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Add back nonce #5078

merged 2 commits into from
Sep 9, 2022

Conversation

MinnDevelopment
Copy link
Contributor

Closes #5076

SQKo added a commit to SQKo/DiscordPHP that referenced this pull request Jun 30, 2022
@@ -893,6 +893,7 @@ Files must be attached using a `multipart/form-data` body as described in [Uploa
| Field | Type | Description |
| --------------------- | ------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| content?\* | string | Message contents (up to 2000 characters) |
| nonce? | integer or string | Can be used to verify a message was sent (up to 25 characters) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 25 characters only makes sense for the string type, but nonce can also be and int

@@ -893,6 +893,7 @@ Files must be attached using a `multipart/form-data` body as described in [Uploa
| Field | Type | Description |
| --------------------- | ------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| content?\* | string | Message contents (up to 2000 characters) |
| nonce? | integer or string | Can be used to verify a message was sent (up to 25 characters) |
Copy link
Contributor

@splatterxl splatterxl Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| nonce? | integer or string | Can be used to verify a message was sent (up to 25 characters) |
| nonce? | integer or string | only in the `MESSAGE_CREATE` event, can be used to verify a message was sent (up to 25 characters) |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarification about removal of nonce field in Channel->Create Message endpoint
5 participants