-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back nonce #5078
Merged
Merged
Add back nonce #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
commented
Jun 17, 2022
SQKo
added a commit
to SQKo/DiscordPHP
that referenced
this pull request
Jun 30, 2022
shaydewael
reviewed
Jul 15, 2022
MinnDevelopment
commented
Jul 15, 2022
shaydewael
reviewed
Jul 15, 2022
docs/resources/Channel.md
Outdated
@@ -893,6 +893,7 @@ Files must be attached using a `multipart/form-data` body as described in [Uploa | |||
| Field | Type | Description | | |||
| --------------------- | ------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| content?\* | string | Message contents (up to 2000 characters) | | |||
| nonce? | integer or string | Can be used to verify a message was sent (up to 25 characters) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 25 characters only makes sense for the string type, but nonce can also be and int
splatterxl
reviewed
Sep 1, 2022
docs/resources/Channel.md
Outdated
@@ -893,6 +893,7 @@ Files must be attached using a `multipart/form-data` body as described in [Uploa | |||
| Field | Type | Description | | |||
| --------------------- | ------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| content?\* | string | Message contents (up to 2000 characters) | | |||
| nonce? | integer or string | Can be used to verify a message was sent (up to 25 characters) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| nonce? | integer or string | Can be used to verify a message was sent (up to 25 characters) | | |
| nonce? | integer or string | only in the `MESSAGE_CREATE` event, can be used to verify a message was sent (up to 25 characters) | |
appellation
force-pushed
the
patch-nonce
branch
from
September 9, 2022 21:25
4ca7785
to
6f2559b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5076