add type query param for get reactions endpoint #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaw0r3k
reviewed
Aug 25, 2023
docs/resources/Channel.md
Outdated
| | limit? | integer | Max number of users to return (1-100) | 25 | | ||
| | Field | Type | Description | Default | | ||
| |--------|-----------|--------------------------------------------------|---------| | ||
| | type? | integer | The reaction type (0 for normal and 1 for super) | 0 | |
There was a problem hiding this comment.
Cant we use there reaction type instead of just numbers?
There was a problem hiding this comment.
The author of this PR can't change anything with the API and is only documenting what is already there. I believe your feedback is going to the wind.
There was a problem hiding this comment.
well not what i meant
just make a table for reaction type
to show NORMAL = 0 and BURST = 1
easier to mention afterwards
1 task
colinloretz
approved these changes
May 15, 2024
6 tasks
suneettipirneni
added a commit
to twilight-rs/twilight
that referenced
this pull request
Jul 13, 2024
Refs: - discord/discord-api-docs#6375 - discord/discord-api-docs#6377 This PR renames the old `ReactionType` to `EmojiReactionType` as the concept of a reaction type now exists in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing on #6056 (#6056 (comment))