Documentation for ScheduledEvent.recurrence_rule #7058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DV8FromTheWorld
requested review from
shaydewael
and removed request for
a team
|
Note, awaiting a PR merge in the |
colinloretz
reviewed
Aug 5, 2024
colinloretz
approved these changes
Aug 5, 2024
mpeterson2
approved these changes
Aug 5, 2024
Comment on lines
+145
to
+151
| - The following are current allowed "sets" | ||
| - Monday - Friday (`[0, 1, 2, 3, 4]`) | ||
| - Tuesday - Saturday (`[1, 2, 3, 4, 5]`) | ||
| - Sunday - Thursday (`[6, 0, 1, 2, 3]`) | ||
| - Friday & Saturday (`[4, 5]`) | ||
| - Saturday & Sunday (`[5, 6]`) | ||
| - Sunday & Monday (`[6, 0]`) |
There was a problem hiding this comment.
one interesting thing we could note here is that we store the times in UTC. This means that a user in a different timezone may schedule an event for their Saturday/Sunday but this will actually be stored as Sunday/Monday. That's why those types of sets are allowed.
Co-authored-by: Colin Loretz <colin.loretz@discordapp.com>
sebm253
added a commit
to disgoorg/disgo
that referenced
this pull request
Aug 6, 2024
4 tasks
This was referenced Aug 15, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the
guild_scheduled_event'srecurrence_rule.As is evidenced in the documentation, the
recurrence_ruleis heavily restricted right now and is based on the current limitations present in the app.Solves:
recurrence_rulein Guild Scheduled Event #6799recurrence_rule.endreturns "This field is not supported for recurring events." #7020