Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Add poll_result Message/Embed Type #3870

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Fleny113
Copy link
Member

Add PollResult (46) message type and poll_result embed type.

This does not include the typings for poll_result embeds fields.

@Fleny113 Fleny113 self-assigned this Aug 17, 2024
@Fleny113 Fleny113 requested a review from a team as a code owner August 17, 2024 09:17
@github-actions github-actions bot added pkg-types Affects the types package t-feat A new feature w-unverified This has not been verified labels Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (b3a8c86) to head (86f8c30).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3870      +/-   ##
==========================================
- Coverage   77.04%   76.85%   -0.20%     
==========================================
  Files         204      204              
  Lines       26147    26148       +1     
  Branches      546      515      -31     
==========================================
- Hits        20145    20095      -50     
- Misses       5993     6044      +51     
  Partials        9        9              
Flag Coverage Δ *Carryforward flag
bot 58.13% <ø> (-0.38%) ⬇️
bot-e2e 58.18% <ø> (-0.26%) ⬇️ Carriedforward from afb01af
bot-unit 49.67% <ø> (ø)
discordeno 34.71% <ø> (ø)
discordeno-unit 34.71% <ø> (ø)
gateway 67.25% <ø> (ø)
gateway-integration 67.25% <ø> (ø)
gateway-unit 31.46% <ø> (ø)
rest 82.93% <ø> (-0.28%) ⬇️
rest-e2e 26.85% <ø> (-0.25%) ⬇️ Carriedforward from afb01af
rest-unit 70.75% <ø> (ø)
types 100.00% <100.00%> (ø)
types-unit 100.00% <100.00%> (ø)
utils 82.82% <ø> (ø)
utils-unit 82.82% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lts20050703 lts20050703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AwesomeStickz
Copy link
Member

This does not include the typings for poll_result embeds fields.

Any reason why?

@Fleny113
Copy link
Member Author

Any reason why?

I don't know how to type them.

The issue is that to type them i need to change DiscordEmbedField in such a way that makes those fields type-safe but idk how to do that without making A. a type mess B. breaking stuff

@Fleny113 Fleny113 merged commit 9e516a0 into main Aug 21, 2024
38 checks passed
@Fleny113 Fleny113 deleted the feat/add-pollResult-message-type branch August 21, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg-types Affects the types package t-feat A new feature w-unverified This has not been verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants