Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes storyteller #6009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removes storyteller #6009

wants to merge 1 commit into from

Conversation

drexample
Copy link
Contributor

Yes, really

About The Pull Request

Yeah, this ACTUALLY removes the storyteller.
Obviously DNM.
I either finish new system in a week or so, or I'm offering 50 bucks to whoever is brave (or stupid) enough to take onto making it into something passable.

Why It's Good For The Game

I can already feel the level of shitcode in this codebase being halved.

Changelog

🆑
del: Removed the storyteller
/:cl:

@drexample
Removes storyteller
a3cee7a 
Yes, really
TheShown911
TheShown911 approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@TheShown911 TheShown911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this if the storyteller isn't finished in time

@Evankhell561
Copy link
Contributor

time to marge

Iglpigl
Iglpigl approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@Iglpigl Iglpigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well more then seven days passed, got 2 approvals already, and we can appointment Rosalimo as a suitable replacement to replace the whole storyteller, looks good to be merged honestly.

@drexample
Copy link
Contributor Author

Well more then seven days passed, got 2 approvals already, and we can appointment Rosalimo as a suitable replacement to replace the whole storyteller, looks good to be merged honestly.

The storyteller rework is ready, but I decided to rework storyevents a little alongside it and it takes longer than I anticipated.

TheShown911
TheShown911 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@TheShown911 TheShown911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve once again.

@SleepyJoe2137
Copy link
Contributor

image

@drexample
Copy link
Contributor Author

screams

@CeUvi
Copy link
Contributor

CeUvi commented May 7, 2021

merge now

@TheShown911
Copy link
Contributor

I approve for the third time.

@Wouju
Copy link
Contributor

Wouju commented May 14, 2021

Well more then seven days passed, got 2 approvals already, and we can appointment Rosalimo as a suitable replacement to replace the whole storyteller, looks good to be merged honestly.

I have already scanned Rosalimo's brain and created a perfect carbon copy of him, we can now attach the Rosalimo clone to the server and have them be our new storyteller

@MLGTASTICa
Copy link
Contributor

finish when , we cant keep the TE as the storyteller al the timee.

TheShown911
TheShown911 approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@TheShown911 TheShown911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve for the fourth time.

@L74814
Copy link
Contributor

L74814 commented Jul 16, 2021

when

@github-actions github-actions bot added the Merge Conflict Merge Conflict label Sep 3, 2021
@Kegdo
Copy link
Contributor

Kegdo commented Nov 14, 2021

wh en

TheShown911
TheShown911 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@TheShown911 TheShown911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Evankhell561
Evankhell561 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@Evankhell561 Evankhell561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok x2

@FortuneMaster
Copy link

What did we expect from the PR made in april?

@UltraNumeron
Copy link

its been a year

@ValoTheValo
Copy link
Contributor

it has now been exactly 500 days since nestor said he would fix the storyteller "in a week"
71 Weeks have passed since then

@L74814
Copy link
Contributor

L74814 commented Sep 7, 2022

when

Firefox13
Firefox13 requested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@Firefox13 Firefox13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drexample When

@SirRichardFrancis SirRichardFrancis mentioned this pull request Dec 19, 2022
Closed
TheShown911
TheShown911 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@TheShown911 TheShown911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been... 2 years...

@Skyfiremighty
Copy link

💀

@SirRichardFrancis
Copy link
Member

image

@Skyfiremighty
Copy link

I forgor I commented on this MERGEEEEEEEEEEEEEEEE IT!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@itchybones
Copy link
Contributor

le merge when

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Firefox13 Firefox13 Firefox13 requested changes

@SirRichardFrancis SirRichardFrancis SirRichardFrancis approved these changes

@TheShown911 TheShown911 TheShown911 approved these changes

@Iglpigl Iglpigl Iglpigl approved these changes

@Evankhell561 Evankhell561 Evankhell561 approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE Merge Conflict Merge Conflict REALLY DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.