-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire rework [test required] #7329
Open
Humonitarian
wants to merge
21
commits into
discordia-space:master
Choose a base branch
from
Humonitarian:fire-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ready? Me ape. Ape likes fire. |
If this is ready, I'll throw it onto the test server later. |
Heads up, there will be a merge conflict if the mech PR is merged. |
Fire when. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Implements a new way for fire to work. Fire no longer causes heat, instead damages directly, as well as increases damage from the environment (for humans).
Heat does now cause you to catch on fire, but burning dissipates over time. This means if you heat up enough and catch on fire, after a while the fire will burn out, avoiding the monkeys burning for hours incident.
Some weapons, specifically plasma and more specifically heatwave-based weapons will now cause the body temperature of targets to boost up, which can as a result ignite them and do considerable damage over time. Also, beware the ultra-modded industrial welder.
Flamethrowers are capable of quickly igniting large areas, and rapidly raising body temperature, while lacking any actual direct damage.
Part 1: Body temperature and fire handling, fire causes burn damage
Part 1.5: Rework bodytemperature-affecting reagents
Part 2: Heat damage for weapons
Part 2.1: Cold damage for weapons
Part 2.2: Temperature gun
Part 3: Flamethrower rework
Why It's Good For The Game
Fire is fun, heat damage is bad.
Changelog
🆑
add: fire damage and heat overhaul
balance: heat damage significantly reduced
balance: most fire- and cold-based weapons and reagents reworked
/:cl: