Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire rate and burst fire fix #7972

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BigHatLogan-dev
Copy link
Contributor

About The Pull Request

Fixes an issue where fire delay would set a shorter click cooldown than burst delay, causing certain guns to be able to fire multiple bursts at once. Includes Humonitarian's shooting loop cleanup.

Why It's Good For The Game

Bug fixes and cleanup

Testing

  • Live test

Changelog

🆑
tweak: Click cooldown from firing uses both burst delay and fire delay
code: Changed the shooting loop to use sleep() instead of spawn(), uses Humonitarian's logic
code: Moved a define to weapons.dm
/:cl:

BigHatLogan-dev and others added 2 commits December 20, 2022 22:04
Co-authored-by: Humonitarian <61586732+Humonitarian@users.noreply.github.com>
@github-actions github-actions bot added the Merge Conflict Merge Conflict label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant