-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge #8229
base: master
Are you sure you want to change the base?
Purge #8229
Conversation
removes Blob Event removes Viscerators removes electropacks removes "Send Emergency Message" verb removes some unused files removes outdated portrayal of Syndicate mobs
I love removing code and then refusing to add any other features to fill in the feature void ,especially when said features are not extremly prone to bugs and have proven to work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two blank lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, would rather not do a commit purely for a single newline though.
Dont remove the blob. shock pack and electric chair aren't even used but why remove blob? |
No, |
joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime. |
Join while logged in then. |
People use manhacks and vivisectors what the hell are you on about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove manhack grenades.
Some of these changes are controversial so a little more explaining on why it's good would be appreciated.
its not due to a runtime its litteraly a server config change by default to not allow guest keys. Just change the config. |
Cam also be changed live in server tab |
while guest keys may not runtime, lacking any key at all does runtime, and can be done by running the game server without running a BYOND client. |
About The Pull Request
This PR removes the old Syndicate Mobs, the Blob Event, the Shock Pack and Electric Chair, and a variety of unused code.
Why It's Good For The Game
the less old code there is, the less tech debt there is.
Testing
launched properly, joined game, saw no abnormalities, walked around, saw no abnormalities
Changelog
🆑
del: Removed Blob Event
del: Removed Electropack
del: Removed Manhack Grenades and Viscerators
code: removed a variety of unused files
/:cl: