Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CDNRoutes): inconsistency in route and wrong JSDoc #1033

Merged
merged 5 commits into from
Jul 20, 2024
Merged

fix(CDNRoutes): inconsistency in route and wrong JSDoc #1033

merged 5 commits into from
Jul 20, 2024

Conversation

Backiscute
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged: It fixes an inconsistency in the guildIcon cdn route. This route does not start with / like the rest of the routes. It also fixes it's JSDoc which is completely wrong.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR: None

@Backiscute Backiscute requested review from a team as code owners July 18, 2024 23:00
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:16pm

@almeidx almeidx changed the title Fix inconsistency in route and fix wrong JSDoc fix(CDNRoutes): inconsistency in route and wrong JSDoc Jul 19, 2024
almeidx
almeidx requested changes Jul 19, 2024
View reviewed changes
rest/v10/index.ts Show resolved Hide resolved
vaporoxx
vaporoxx suggested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@vaporoxx vaporoxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new route in the documentation doesn't match the actual route

Also while you're at it, the documentation for guildMemberAvatar is missing /avatars

deno/rest/v10/mod.ts Outdated Show resolved Hide resolved
deno/rest/v9/mod.ts Outdated Show resolved Hide resolved
rest/v10/index.ts Outdated Show resolved Hide resolved
rest/v9/index.ts Outdated Show resolved Hide resolved
@vladfrangu vladfrangu merged commit eb7b3d9 into discordjs:main Jul 20, 2024
6 checks passed
@MAPXOR12 MAPXOR12 mentioned this pull request Aug 13, 2024
Open
@SkyDev125 SkyDev125 mentioned this pull request Aug 13, 2024
Merged
@0xhaaaash 0xhaaaash mentioned this pull request Aug 13, 2024
Open
@theKerosen theKerosen mentioned this pull request Aug 13, 2024
Open
@SpazElectro SpazElectro mentioned this pull request Aug 19, 2024
Open
This was referenced Sep 1, 2024
Open
Open
@mezotv mezotv mentioned this pull request Sep 6, 2024
Closed
@0xhaaaash 0xhaaaash mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 6, 2024
Open
Open
@whizbangpop whizbangpop mentioned this pull request Sep 7, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 8, 2024
Open
@Pigot12 Pigot12 mentioned this pull request Sep 9, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 10, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 10, 2024
Open
@theKerosen theKerosen mentioned this pull request Sep 10, 2024
Open
This was referenced Sep 11, 2024
Open
Open
Open
@theKerosen theKerosen mentioned this pull request Sep 13, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Sep 14, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 14, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 14, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 17, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 17, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Sep 17, 2024
Open
@theKerosen theKerosen mentioned this pull request Sep 17, 2024
Open
@0xhaaaash 0xhaaaash mentioned this pull request Sep 19, 2024
Open
@VicDario VicDario mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaporoxx vaporoxx vaporoxx approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@almeidx almeidx Awaiting requested review from almeidx

Assignees
No one assigned
Labels
semver:patch topic:rest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Backiscute @almeidx @vaporoxx @vladfrangu