Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageEmbed): remove deprecation for EmbedType #1187

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

HotDog640
Copy link

@HotDog640 HotDog640 commented Dec 27, 2024

close #1186

Discord API documentation removed the deprecation message for EmbedType at discord/discord-api-docs#7050. This PR undeprecates the associated property and enum.

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 11:42pm

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HotDog640! Taking a look at commit c9c768c, it seems that you forgot to run npm run build:deno. Here are the files that are different from the base:

Please run npm run build:deno and commit the results to update the deno types.

@HotDog640
Copy link
Author

Thanks for the help, hopefully all should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIEmbed.type and EmbedType deprecated
2 participants