Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change xID to xId #159

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Jul 19, 2021

Please describe the changes this PR makes and why it should be merged:

I think you have heard of discordjs/discord.js#6036, well, I ported the changes here so the names are consistent between the two.

I also didn't update v6 since those don't seem to be changed, but I can update them if requested.

Reference Discord API Docs PRs or commits:

N/a.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I am still getting used to this

@iCrawl
Copy link
Member

iCrawl commented Jul 19, 2021

Just close your eyes and merge it quick 👍

@vladfrangu vladfrangu merged commit 323e531 into discordjs:main Jul 19, 2021
@kyranet kyranet deleted the refactor/change-id-convention branch July 19, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants