fix(Typings): use overloading to have more specific typings

discordjs · Nov 8, 2020 · 6ff2d17 · 6ff2d17
1 parent 6aefbb3
commit 6ff2d17
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/typings/index.d.ts b/typings/index.d.ts
@@ -1374,9 +1374,12 @@ declare module 'discord.js' {
     public readonly ids: number[];
     public mode: ShardingManagerMode;
     public parentPort: any | null;
-    public broadcastEval(script: string, shard?: number): Promise<any> | Promise<any[]>;
-    public broadcastEval<T>(fn: (client: Client) => T, shard?: number): Promise<T> | Promise<T[]>;
-    public fetchClientValues(prop: string, shard?: number): Promise<any> | Promise<any[]>;
+    public broadcastEval(script: string): Promise<any[]>;
+    public broadcastEval(script: string, shard: number): Promise<any>;
+    public broadcastEval<T>(fn: (client: Client) => T): Promise<T[]>;
+    public broadcastEval<T>(fn: (client: Client) => T, shard: number): Promise<T>;
+    public fetchClientValues(prop: string): Promise<any[]>;
+    public fetchClientValues(prop: string, shard: number): Promise<any>;
     public respawnAll(shardDelay?: number, respawnDelay?: number, spawnTimeout?: number): Promise<void>;
     public send(message: any): Promise<void>;
 
@@ -1406,9 +1409,11 @@ declare module 'discord.js' {
     public token: string | null;
     public totalShards: number | 'auto';
     public broadcast(message: any): Promise<Shard[]>;
-    public broadcastEval(script: string, shard?: number): Promise<any> | Promise<any[]>;
+    public broadcastEval(script: string): Promise<any[]>;
+    public broadcastEval(script: string, shard: number): Promise<any>;
     public createShard(id: number): Shard;
-    public fetchClientValues(prop: string, shard?: number): Promise<any> | Promise<any[]>;
+    public fetchClientValues(prop: string): Promise<any[]>;
+    public fetchClientValues(prop: string, shard: number): Promise<any>;
     public respawnAll(
       shardDelay?: number,
       respawnDelay?: number,