refactor(resolveColor): Prioritise number type check (#10116)

* refactor(resolveColor): prioritise number type check * refactor: prefer `!Number.isInteger()` --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
discordjs · Feb 3, 2024 · d4472f8 · d4472f8
1 parent b16647e
commit d4472f8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/discord.js/src/util/Util.js b/packages/discord.js/src/util/Util.js
@@ -289,12 +289,12 @@ function resolveColor(color) {
     resolvedColor = (color[0] << 16) + (color[1] << 8) + color[2];
   }
 
-  if (resolvedColor < 0 || resolvedColor > 0xffffff) {
-    throw new DiscordjsRangeError(ErrorCodes.ColorRange);
+  if (!Number.isInteger(resolvedColor)) {
+    throw new DiscordjsTypeError(ErrorCodes.ColorConvert, color);
   }
 
-  if (typeof resolvedColor !== 'number' || Number.isNaN(resolvedColor)) {
-    throw new DiscordjsTypeError(ErrorCodes.ColorConvert, color);
+  if (resolvedColor < 0 || resolvedColor > 0xffffff) {
+    throw new DiscordjsRangeError(ErrorCodes.ColorRange);
   }
 
   return resolvedColor;