Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suggested use of utf-8-validate since node 18.14+ supports it natively #10530

Closed
JMTK opened this issue Oct 2, 2024 · 0 comments · Fixed by #10531
Closed

Remove suggested use of utf-8-validate since node 18.14+ supports it natively #10530

JMTK opened this issue Oct 2, 2024 · 0 comments · Fixed by #10531

Comments

@JMTK
Copy link
Contributor

JMTK commented Oct 2, 2024

Which application or package is this feature request for?

discord.js

Feature

As of v18.14.0, the ws package will prefer using the native function if it exists.

Reference: https://github.com/websockets/ws/blob/019f28ff1ffddfcdc428d1de5ecd98648057a2ab/lib/validation.js#L138

Ideal solution or implementation

Remove from the README.md. bufferutil would still be required

Alternative solutions or implementations

No response

Other context

The biggest issue is that the current engine is >=18, but this is only on 18.14+. For that reason, that might need to be semver major still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant