Editing of messages fails (Cannot read properties of undefined (reading 'channels'))

[The-LukeZ]

Which package is this bug report for?

discord.js

Issue description

1. Have a message
2. Try to edit it
3. Error: Cannot read properties of undefined (reading 'channels')

Code sample

let message: Message | null = null;
try {
  let channel = (await getAndValidateChannel(
    parsedLink.channelId,
    ctx.guild,
    ChannelType.GuildText,
    ChannelType.GuildAnnouncement
  )) as TextChannel | NewsChannel;
  message = await channel.messages.fetch(parsedLink.messageId);
  // Validate message and stuff, but not important.
} catch (err) {
  console.error(inspect(err));
  return;
}

let data = {
  action: "edit",
  where: message,
};

setCacheData(ctx.guildId, ctx.user.id, data);

// Later, in another function

/*
- panelData.action can only be "edit" or "send"
- panelData.where is a message when panelData.action is "edit" ; a Text-/NewsChannel when panelData.action is "send"
- messageArgs is of type MessageEditOptions
*/

let panel: Message;
try {
  panel = await panelData.where[panelData.action](messageArgs);
} catch (err) {
  await ctx.reply({
    embeds: [
      {
        title: `Panel not ${panelData.where instanceof Message ? "edited" : "sent"}`,
        description: "" + `${err}` + "```",
        color: 0xff0000,
      },
    ],
  });
  return;
}

Versions

• discord.js: 14.17.3
• npm: 11.0.0
• Typescript: 5.2.6
• Server OS: Linux Ubuntu 24.04.1 LTS

Issue priority

Medium (should be fixed soon)

Which partials do you have configured?

Channel

Which gateway intents are you subscribing to?

Guilds, GuildMembers, GuildWebhooks, GuildMessages, DirectMessages, MessageContent, AutoModerationConfiguration, AutoModerationExecution

I have tested this issue on a development release

No response

[monbrey]

Please include the full error stack to assist in debugging the issue.

[The-LukeZ]

Here you go :)
I just replaced the bot's root directory with <directory>

TypeError: Cannot read properties of undefined (reading 'channels')
    at get channel (/home/<directory>/node_modules/discord.js/src/structures/Message.js:507:24)
    at Message.edit (/home/<directory>/node_modules/discord.js/src/structures/Message.js:828:15)
    at Object.submit (file:///home/<directory>/dist/components/utils/ticketsConfig/panel.js:544:56)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Object.run (file:///home/<directory>/dist/components/configTickets.js:16:17)
    at async Client.<anonymous> (file:///home/<directory>/dist/index.js:131:13)

[monbrey]

This error suggests that Message#client is undefined, which should never happen using a Message instead that was constructed by discord.js. Are you constructing your own message object, or incorrectly typecasting somewhere?

[The-LukeZ]

I'm fetching it. Look at the code from the initial report.

[monbrey]

The line panel = await panelData.where[panelData.action](messageArgs); lifts the edit or send functions from its this context, which breaks its internal bindings. You cannot call instance methods which rely on this context in this way.

[The-LukeZ]

well, it's also not working when I do it like this:

try {
  if (panelData.action == "edit") {
    panel = await panelData.where.edit(messageArgs); // panelData.where is a Message
  } else {
    panel = await panelData.where.send(messageArgs); // panelData.where is a Text or NewsChannel
  }
}

I've tested it.

[The-LukeZ]

Also, I've looked through my code and I saw this:

/**
 *
 * @param channelId - The channel ID to fetch
 * @param guild - The guild to fetch the channel from
 * @param channelTypes - The channel types to validate the channel for
 * @returns The channel if it exists and is of the correct type, otherwise `null`
 */
async function getAndValidateChannel(
  channelId: string,
  guild: Guild,
  ...channelTypes: ChannelType[]
) {
  const _channel = await guild.channels.fetch(channelId);
  if (
    !(
      channelTypes.length
        ? channelTypes
        : [ChannelType.GuildText, ChannelType.GuildAnnouncement]
    ).includes(_channel.type)
  )
    return null;
  return _channel;
}

// Later

let channel = (await getAndValidateChannel(
  parsedLink.channelId,
  ctx.guild,
  ChannelType.GuildText,
  ChannelType.GuildAnnouncement
)) as TextChannel | NewsChannel;

Maybe it is because of ctx.guild. ctx is a ModalMessageModalSubmitInteraction

[monbrey]

I recommend opening a thread in the support section of our Discord server for further help debugging this. I don't see this as a library bug, as Message#client is always defined for messages properly constructed by discord.js.

Your error message and stack shows that either Message#client or the this context has been compromised in some way.

I also wouldn't call this a "minimal reproducible code sample" as it includes your own custom validation functions, some of which you chose to omit, and may be impacting the end result.

[The-LukeZ]

I recommend opening a thread in the support section of our Discord server for further help debugging this. I don't see this as a library bug, as Message#client is always defined for messages properly constructed by discord.js.

Your error message and stack shows that either Message#client or the this context has been compromised in some way.

I also wouldn't call this a "minimal reproducible code sample" as it includes your own custom validation functions, some of which you chose to omit, and may be impacting the end result.

Okay, will do tomorrow 👍🏻