types: change Awaitable<void> to void

[advaith1]

Please describe the changes this PR makes and why it should be merged:

Currently, event listeners require a function that returns Awaitable<void>. However, this prevents returning a function call that returns a value for early execution (e.g. return interaction.reply('error')). This PR changes => Awaitable<void> to => void, since void functions can return anything. This will remove the restriction and allow any function, bringing it in line with Node's standard EventEmitters, as well as previous discord.js behavior.

Status and versioning classification:

• I know how to update typings and have done so, or typings don't need updating
• This PR only includes non-code changes, like changes to documentation, README, etc.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
discord-js	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2023 1:52pm
discord-js-guide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2023 1:52pm

[Qjuh]

return void interaction.reply(…); would be the correct fix for your use-case. As returning something from an event listener while it will never reach any place that uses it should not be done imho.

[advaith1]

This is a normal pattern, and TypeScript explicitly supports it with the standard => void. This change makes discord.js consistent with Node's standard EventEmitter, async_event_emitter (used by djs/core), and previous versions of discord.js.

[Qjuh]

async_event_emitter returns Awaitable<void> too though.

[vladfrangu]

async_event_emitter returns Awaitable<void> too though.

No it doesn't, it uses void

[Qjuh]

Oh, my bad, I was looking at the Listener type instead of the type used in on(…) assuming it was used there…