Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: use readonly array / collection types for user input #10045

Merged
merged 5 commits into from
Feb 23, 2024
Merged

types: use readonly array / collection types for user input #10045

merged 5 commits into from
Feb 23, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Dec 10, 2023

Please describe the changes this PR makes and why it should be merged:
Added an ESLint rule to enforce the use of readonly Array and Collection types in function/method parameters and interface properties

Status and versioning classification:

@almeidx almeidx requested a review from a team as a code owner December 10, 2023 17:56
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 0:27am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 0:27am

@almeidx almeidx requested a review from Jiralite December 10, 2023 17:56
@Jiralite
Copy link
Member

Jiralite commented Dec 10, 2023 •
edited
Loading

Is there one for const type parameters? Also, shouldn't we enforce these changes to all packages?

@Jiralite Jiralite added this to the discord.js 14.15 milestone Dec 10, 2023
@Jiralite Jiralite removed this from the discord.js 14.15 milestone Dec 10, 2023
@almeidx almeidx force-pushed the types/readonly-array branch from 79e11cb to ce71c13 Compare December 10, 2023 21:32
@almeidx almeidx force-pushed the types/readonly-array branch 2 times, most recently from 6b2c2bc to 6ab7685 Compare December 24, 2023 18:10
@almeidx almeidx requested a review from vladfrangu January 18, 2024 21:18
@Jiralite Jiralite added this to the discord.js 14.15 milestone Feb 3, 2024
vladfrangu
vladfrangu approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't break user code

@vladfrangu
Copy link
Member

Also this needs a rebase

@almeidx almeidx force-pushed the types/readonly-array branch from 6ab7685 to 7f4204b Compare February 23, 2024 00:27
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@almeidx almeidx mentioned this pull request Aug 20, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
Development

Successfully merging this pull request may close these issues.
6 participants
@almeidx @Jiralite @vladfrangu @ThinkThoughtThunk @iCrawl @kyranet