Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(oauth2): remove unnecessary dependency on 'node:url' #10141

Merged
merged 1 commit into from
Feb 21, 2024
Merged

refactor(oauth2): remove unnecessary dependency on 'node:url' #10141

merged 1 commit into from
Feb 21, 2024

Conversation

mattrubin
Copy link
Contributor

@mattrubin mattrubin commented Feb 20, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
This change removes an unnecessary dependency on 'node:url', which fixes a runtime error when using '@discordjs/core/http-only' on Cloudflare Workers.

Related links:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@mattrubin
refactor(oauth2): remove unnecessary dependency on 'node:url'
4f080d7 
This change fixes a runtime error when using '@discordjs/core/http-only' on Cloudflare Workers.
@mattrubin mattrubin requested a review from a team as a code owner February 20, 2024 23:13
@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 11:13pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 11:13pm

@Jiralite Jiralite added this to the core 1.2.0 milestone Feb 21, 2024
@kodiakhq kodiakhq bot merged commit 906ade9 into discordjs:main Feb 21, 2024
22 checks passed
@mattrubin mattrubin deleted the remove-unnecessary-node-dependency branch February 21, 2024 23:47
@mattrubin
Copy link
Contributor Author

Thanks, all!
Is there any timeline for when a new version of @discordjs/core might be released?

@sdanialraza
Copy link
Contributor

Is there any timeline for when a new version of @discordjs/core might be released?

There is no ETA, it'll be released when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@suneettipirneni suneettipirneni Awaiting requested review from suneettipirneni

Assignees
No one assigned
Labels
packages:core refactor semver:patch
Projects
discord.js
Archived in project
Milestone
core 1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mattrubin @sdanialraza @vladfrangu @kyranet @Jiralite