Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Embed): address equals method issue #10152

Merged
merged 2 commits into from
Mar 24, 2024
Merged

fix(Embed): address equals method issue #10152

merged 2 commits into from
Mar 24, 2024

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Resolves #9095

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza requested a review from a team as a code owner February 24, 2024 02:38
@vercel Vercel
Copy link

vercel bot commented Feb 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 2:42pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 2:42pm

@sdanialraza sdanialraza force-pushed the fix/address-equals-method-issue branch from 3b25113 to e857cd3 Compare February 24, 2024 06:21
almeidx
almeidx requested changes Feb 25, 2024
View reviewed changes
packages/discord.js/src/structures/Embed.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Embed.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/Embed.js Outdated Show resolved Hide resolved
@sdanialraza sdanialraza force-pushed the fix/address-equals-method-issue branch from e857cd3 to 5e59470 Compare February 26, 2024 12:06
@sdanialraza sdanialraza requested a review from almeidx March 4, 2024 17:25
@kodiakhq kodiakhq bot merged commit ddc927f into discordjs:main Mar 24, 2024
6 checks passed
@sdanialraza sdanialraza deleted the fix/address-equals-method-issue branch March 24, 2024 15:05
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@lockyz lockyz mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@WhyAydan WhyAydan mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@Azzraya Azzraya mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 26, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embed#equals() will never equal EmbedBuilder#data
4 participants
@sdanialraza @vladfrangu @SpaceEEC @almeidx