Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessageManager): poll methods don't need a channel id #10249

Merged
merged 2 commits into from
May 4, 2024
Merged

fix(MessageManager): poll methods don't need a channel id #10249

merged 2 commits into from
May 4, 2024

Conversation

didinele
Copy link
Member

@didinele didinele commented May 4, 2024

average discord.js release (blundered)

@didinele didinele requested a review from a team as a code owner May 4, 2024 18:59
@vercel Vercel
Copy link

vercel bot commented May 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 7:03pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 7:03pm

almeidx
almeidx requested changes May 4, 2024
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing type updates
  • fetchPollAnswerVoters needs to be updated too
  • both of these methods are being used in the Poll and PollAnswer classes

@Jiralite Jiralite added this to the discord.js 14.15.1 milestone May 4, 2024
@didinele didinele changed the title fix(MessageManager): end poll does not need channel id fix(MessageManager): poll methods don't need a channel id May 4, 2024
@didinele didinele requested a review from almeidx May 4, 2024 19:04
@Jiralite Jiralite removed the in review label May 4, 2024
@kodiakhq kodiakhq bot merged commit 0474a43 into main May 4, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the fix/channel-id-param branch May 4, 2024 19:06
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@lockyz lockyz mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request May 25, 2024
Open
@WhyAydan WhyAydan mentioned this pull request May 26, 2024
Open
@User5029 User5029 mentioned this pull request May 26, 2024
Open
@StrezlessMusick StrezlessMusick mentioned this pull request May 26, 2024
Open
@The0mikkel The0mikkel mentioned this pull request May 26, 2024
Closed
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@MinhhTien MinhhTien mentioned this pull request Aug 22, 2024
Closed
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.15.1
Development

Successfully merging this pull request may close these issues.
5 participants
@didinele @vladfrangu @iCrawl @almeidx @Jiralite