fix: Throw error on no message id for Message#fetchReference()
#10295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jiralite
changed the title
Message#fetchReferece()
Jiralite
changed the title
Message#fetchReferece()Message#fetchReference()
Qjuh
suggested changes
May 21, 2024
vladfrangu
approved these changes
May 23, 2024
kyranet
approved these changes
May 24, 2024
didinele
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10295 +/- ##
=========================================
+ Coverage 1.42% 1.83% +0.41%
=========================================
Files 64 117 +53
Lines 3238 4912 +1674
Branches 64 71 +7
=========================================
+ Hits 46 90 +44
- Misses 3192 4822 +1630
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jun 24, 2024
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #10294.
Simply put: if there's no message id, throw
ErrorCodes.MessageReferenceMissing.Also, the JSDoc had these properties as
?.?does not indicateundefined—it indicates<type> | null.1Status and versioning classification:
Footnotes
https://jsdoc.app/tags-type ↩