Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consistent debug log spacing #10349

Merged
merged 4 commits into from
Jun 13, 2024
Merged

fix: Consistent debug log spacing #10349

merged 4 commits into from
Jun 13, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jun 13, 2024

Please describe the changes this PR makes and why it should be merged:
In discord.js, indentation of debug log messages were inconsistent with @discordjs/ws. This brings discord.js into same implementation as @discordjs/ws.

Before
Preparing to connect to the gateway...
[WS => Manager] Fetched Gateway Information
    URL: wss://gateway.discord.gg
    Recommended Shards: 1
[WS => Manager] Session Limit Information
    Total: 1000
    Remaining: 980
[WS => Shard 0] Connecting to wss://gateway.discord.gg?v=10&encoding=json
[WS => Shard 0] Waiting for event hello for 60000ms
[WS => Shard 0] Preparing first heartbeat of the connection with a jitter of 0.9639452647332618; waiting 39762ms
[WS => Shard 0] Waiting for identify throttle
[WS => Shard 0] Identifying
        shard id: 0
        shard count: 1
        intents: 1
        compression: none
[WS => Shard 0] Waiting for event ready for 15000ms
[WS => Shard 0] Shard received all its guilds. Marking as fully ready.
After
Preparing to connect to the gateway...
[WS => Manager] Fetched Gateway Information
        URL: wss://gateway.discord.gg
        Recommended Shards: 1
[WS => Manager] Session Limit Information
        Total: 1000
        Remaining: 979
[WS => Shard 0] Connecting to wss://gateway.discord.gg?v=10&encoding=json
[WS => Shard 0] Waiting for event hello for 60000ms
[WS => Shard 0] Preparing first heartbeat of the connection with a jitter of 0.24886133259727927; waiting 10265ms
[WS => Shard 0] Waiting for identify throttle
[WS => Shard 0] Identifying
        shard id: 0
        shard count: 1
        intents: 1
        compression: none
[WS => Shard 0] Waiting for event ready for 15000ms
[WS => Shard 0] Shard received all its guilds. Marking as fully ready.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 4:03pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 4:03pm

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.08%. Comparing base (c5d40d3) to head (c4bf510).

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10349      +/-   ##
==========================================
+ Coverage   63.01%   63.08%   +0.07%     
==========================================
  Files         131      132       +1     
  Lines       16326    16333       +7     
  Branches     1139     1143       +4     
==========================================
+ Hits        10288    10304      +16     
+ Misses       5993     5984       -9     
  Partials       45       45              
Flag Coverage Δ
ws 51.93% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-Authored-By: Synbulat Biishev <contact@syjalo.dev>
@Jiralite Jiralite force-pushed the fix/debug-spacing branch from 3f57d4e to c0f3428 Compare June 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants