fix(GuildAuditLogsEntry): correct mapped AuditLogChange objects
#10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Renegade334
changed the title
AuditLogChange objectsAuditLogChange objects
kyranet
approved these changes
Aug 19, 2024
SpaceEEC
approved these changes
Aug 19, 2024
vladfrangu
approved these changes
Aug 20, 2024
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
…scordjs#10438) * refactor(GuildAuditLogsEntry): correct mapped AuditLogChange objects * test: check union narrowing behaviour of AuditLogChange --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This was referenced Sep 24, 2024
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
…scordjs#10438) * refactor(GuildAuditLogsEntry): correct mapped AuditLogChange objects * test: check union narrowing behaviour of AuditLogChange --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
AuditLogChangeimply that theoldandnewparameters are optional, matching the optionalold_valueandnew_valueparameters of theAPIAuditLogChangeobject passed into the map function. This wasn't reflected by the previous implementation, where these parameters in the output mapped object were always set, but their value wasundefinedif the relevant parameter wasn't set in the source object.oldandnewparameters are truly optional, and are not set if their source parameter is not set.AuditLogChangeis now a correctly mapped union type, which means that it's now possible to narrow the object type based onchange.key.Resolves #10437.
Status and versioning classification: