-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(OAuth2API): add revokeToken
method
#10440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
requested changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is going to fail here. You should run pnpm fmt
almeidx
changed the title
feat(OAuth2API): add 'revokeToken' method
feat(OAuth2API): add Aug 17, 2024
revokeToken
method
Co-authored-by: Almeida <github@almeidx.dev>
Co-authored-by: Almeida <github@almeidx.dev>
Co-authored-by: Almeida <github@almeidx.dev>
almeidx
approved these changes
Aug 17, 2024
kyranet
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little nitpick
SpaceEEC
approved these changes
Aug 19, 2024
kyranet
approved these changes
Aug 20, 2024
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
* feat(OAuth2API): add 'revokeToken' method * Buffer => btoa Co-authored-by: Almeida <github@almeidx.dev> * Response is empty, dont return Co-authored-by: Almeida <github@almeidx.dev> * Redundant override Co-authored-by: Almeida <github@almeidx.dev> * chore: fmt --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Oct 4, 2024
* feat(OAuth2API): add 'revokeToken' method * Buffer => btoa Co-authored-by: Almeida <github@almeidx.dev> * Response is empty, dont return Co-authored-by: Almeida <github@almeidx.dev> * Redundant override Co-authored-by: Almeida <github@almeidx.dev> * chore: fmt --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This change completes the OAuth2 Authorization flow by supporting the
Token Revocation URL
Fixes #10439
This PR relies on:
Status and versioning classification: