Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message reaction crash #10469

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

TAEMBO
Copy link
Contributor

@TAEMBO TAEMBO commented Sep 2, 2024

Please describe the changes this PR makes and why it should be merged:
This PR fixes an edge case where MessageReaction#countDetails was not initialized before a new reaction has been added.
Fixes #10468

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@TAEMBO TAEMBO requested a review from a team as a code owner September 2, 2024 04:47
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 4:47am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 4:47am

@kodiakhq kodiakhq bot merged commit 13dc779 into discordjs:main Sep 2, 2024
7 checks passed
@TAEMBO TAEMBO deleted the fix/message-reaction-crash branch September 2, 2024 07:47
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Sep 9, 2024
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error when bot reacts to messages with Channel partial enabled
4 participants