You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please describe the changes this PR makes and why it should be merged:
I believe that during this merge, "PartialGroupDMChannel" was incorrectly removed from the excluded definition of "TextBasedChannel." This leads to the inability to use the 'send' function on any "TextBasedChannel" Status and versioning classification:
With the introduction of user-installable apps it is now possible for a bot to receive interactions or even messages (through context menu commands) from group dm channels. So no, this was done on purpose and is correct.
aquafenaa
changed the title
Reintroduction of the PartialGroupDMChannel within the exclude of Tex…
types: Reintroduction of the PartialGroupDMChannel within the exclude of Tex…
Sep 3, 2024
With the introduction of user-installable apps it is now possible for a bot to receive interactions or even messages (through context menu commands) from group dm channels. So no, this was done on purpose and is correct.
Understood! Sorry for the hassle then. Is there a separate function I can use to ensure that I am able to send a message to that channel? Or should I just include an extra check to make sure that it isn't a PartialGroupDMChannel?
With the introduction of user-installable apps it is now possible for a bot to receive interactions or even messages (through context menu commands) from group dm channels. So no, this was done on purpose and is correct.
Understood! Sorry for the hassle then. Is there a separate function I can use to ensure that I am able to send a message to that channel? Or should I just include an extra check to make sure that it isn't a PartialGroupDMChannel?
Now you will have to typeguard to ensure the channel has a "send" property. There's some PR's that will add some helper methods to make it easier: #10482
Jiralite
changed the title
types: Reintroduction of the PartialGroupDMChannel within the exclude of Tex…
types: Reintroduction of the PartialGroupDMChannel within the exclude of TextBasedChannel
Sep 4, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aquafenaa
changed the title
Jiralite
changed the title
Please describe the changes this PR makes and why it should be merged:
I believe that during this merge, "PartialGroupDMChannel" was incorrectly removed from the excluded definition of "TextBasedChannel." This leads to the inability to use the 'send' function on any "TextBasedChannel"
Status and versioning classification: