fix(GuildScheduledEvent): handle null recurrence_rule #10543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
approved these changes
Oct 8, 2024
didinele
approved these changes
Oct 8, 2024
Jiralite
requested changes
Oct 9, 2024
There was a problem hiding this comment.
When the recurrence rule is removed, Discord will send null. This means the proposed condition change will result in false where it goes to the else clause where nothing happens. The cached scheduled event is not updated and will be incorrect.
A proposed fix would be to leave the condition as it is and instead do this:
this.recurrenceRule = data.recurrenceRule && {...};When null is received, it will be correctly set to null.
Jiralite
approved these changes
Oct 9, 2024
vladfrangu
approved these changes
Oct 11, 2024
Jiralite
pushed a commit
that referenced
this pull request
Oct 11, 2024
* fix(GuildScheduledEvent): handle null recurrence_rule * refactor: consistency * feat: implement suggested logic change * fix: correct data.recurrence_rule check --------- Co-authored-by: Almeida <github@almeidx.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR handles a null
recurrence_rulevalue inGuildScheduledEvents. If there is no rule, the value appears to always be null rather than not present.Status and versioning classification: