refactor: use cache.get() for snowflakes, resolve() otherwise
#10626
+29
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
didinele
previously approved these changes
Nov 28, 2024
sdanialraza
force-pushed
the
refactor/consistent-use-resolve-cache-get
branch
from
b63cdb3
to
43a7060
Compare
sdanialraza
force-pushed
the
refactor/consistent-use-resolve-cache-get
branch
from
43a7060
to
6b65bad
Compare
sdanialraza
changed the title
resolve instead of cache.get() ?? nullcache.get() for snowflakes, resolve() otherwise
Jiralite
requested changes
Nov 28, 2024
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Jiralite
approved these changes
Nov 28, 2024
vladfrangu
approved these changes
Nov 28, 2024
SpaceEEC
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This makes it consistent to use
cache.get()for snowflakes andresolve()for everything else.Status and versioning classification: