Skip to content

Conversation

@bowenjw
Copy link

@bowenjw bowenjw commented Oct 11, 2025

Please describe the changes this PR makes and why it should be merged:
Update of Modal interaction page to reflect the addition of label, Text Display and Select Menu components

Status and versioning classification:
In Development

@vercel
Copy link

vercel bot commented Oct 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ready Ready Preview Comment Oct 26, 2025 1:33am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 26, 2025 1:33am

Copy link

@thorminate thorminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, my grammar review is done.

Copy link
Member

@almostSouji almostSouji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give this another read-over in terms of reading flow and grammar. I tried to cover everything that wasn't already pointed out, but after applying reviews, this may require some additional or different changes to read well.

Please also review heading nesting levels and make sure they nest as they should (H3 > H4, H4 etc.).

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.33%. Comparing base (0c2975e) to head (e1471d8).
⚠️ Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11169      +/-   ##
==========================================
+ Coverage   44.19%   44.33%   +0.14%     
==========================================
  Files         313      315       +2     
  Lines       18093    18159      +66     
  Branches     1796     1805       +9     
==========================================
+ Hits         7996     8051      +55     
- Misses      10085    10096      +11     
  Partials       12       12              
Flag Coverage Δ
brokers 26.29% <ø> (ø)
builders 79.74% <ø> (+0.14%) ⬆️
collection 100.00% <ø> (ø)
core 0.91% <ø> (ø)
formatters 99.66% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.56% <ø> (ø)
structures 85.19% <ø> (ø)
util 43.28% <ø> (ø)
utilities 6.14% <ø> (-0.03%) ⬇️
voice 60.25% <ø> (ø)
ws 35.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

3 participants