Skip to content

docs: clarify wording for maximum values #11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2025
Merged

docs: clarify wording for maximum values #11231

merged 3 commits into from
Nov 1, 2025
+4 −4

Conversation

@imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Oct 31, 2025

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

@imnaiyar imnaiyar requested review from a team as code owners October 31, 2025 19:55
@imnaiyar imnaiyar requested review from Jiralite and didinele October 31, 2025 19:55
@vercel
Copy link

vercel bot commented Oct 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 1, 2025 2:27pm
discord-js-guide Ignored Ignored Preview Nov 1, 2025 2:27pm

Jiralite
Jiralite requested changes Oct 31, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed instance:

discord.js/packages/builders/src/components/selectMenu/BaseSelectMenu.ts

Lines 49 to 57 in d06d8c0

/**
* Sets the maximum values that must be selected in the select menu.
*
* @param maxValues - The maximum values that must be selected
*/
public setMaxValues(maxValues: number) {
this.data.max_values = maxValues;
return this;
}

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 31, 2025
@imnaiyar imnaiyar requested a review from Jiralite October 31, 2025 20:03
@Jiralite Jiralite changed the title docs(FileUpload): clarify wording docs: clarify wording for maximum values Oct 31, 2025
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Nov 1, 2025
@kodiakhq kodiakhq bot merged commit 06a75e8 into discordjs:main Nov 1, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Nov 1, 2025
@imnaiyar imnaiyar deleted the docs/word branch November 1, 2025 14:35
@Jiralite Jiralite mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

backport-candidate documentation packages:builders packages:discord.js semver:patch

Projects

discord.js
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@imnaiyar @SpaceEEC @didinele @Jiralite