Skip to content

refactor(publish-dev): take ref instead #11236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −16
Open

refactor(publish-dev): take ref instead #11236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b90b33e
refactor(publish-dev): take ref instead
didinele Nov 1, 2025
ce392ca
fix: main checks
didinele Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions .github/workflows/publish-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on:
- cron: '0 */12 * * *'
workflow_dispatch:
inputs:
pull:
description: 'The pull number to check out'
ref:
description: 'The ref to check out'
Copy link
Member

@almeidx almeidx Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to include examples here

required: false
default: 'main'
tag:
Expand Down Expand Up @@ -33,21 +33,12 @@ jobs:
app-id: ${{ vars.DISCORDJS_APP_ID }}
private-key: ${{ secrets.DISCORDJS_APP_KEY_RELEASE }}

- name: Decide ref
id: ref
run: |
if [ -n "${{ github.event.inputs.pull }}" ]; then
echo "ref=refs/pull/${{ github.event.inputs.pull }}/head" >> $GITHUB_OUTPUT
else
echo "ref=refs/heads/main" >> $GITHUB_OUTPUT
fi

- name: Checkout repository
uses: actions/checkout@v5
with:
fetch-depth: 0
token: ${{ steps.app-token.outputs.token }}
ref: ${{ steps.ref.outputs.ref }}
ref: ${{ inputs.ref }}

- name: Install Node.js v22
uses: actions/setup-node@v5
Expand All @@ -63,13 +54,13 @@ jobs:
run: pnpm run build

- name: Checkout main repository (non-main ref)
if: ${{ steps.ref.outputs.ref != 'refs/heads/main' }}
if: ${{ inputs.ref != 'main' }}
uses: actions/checkout@v5
with:
path: 'main'

- name: Install action deps (non-main ref)
if: ${{ steps.ref.outputs.ref != 'refs/heads/main' }}
if: ${{ inputs.ref != 'main' }}
shell: bash
working-directory: ./main
env:
Expand All @@ -79,7 +70,7 @@ jobs:
pnpm install --filter @discordjs/actions --frozen-lockfile --prefer-offline --loglevel error

- name: Publish packages (non-main ref)
if: ${{ steps.ref.outputs.ref != 'refs/heads/main' }}
if: ${{ inputs.ref != 'main' }}
uses: ./main/packages/actions/src/releasePackages
with:
exclude: '@discordjs/docgen'
Expand All @@ -91,7 +82,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish packages (main ref)
if: ${{ steps.ref.outputs.ref == 'refs/heads/main' }}
if: ${{ inputs.ref == 'main' }}
uses: ./packages/actions/src/releasePackages
with:
exclude: '@discordjs/docgen'
Expand Down