-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(guide): update 'Members didn't arrive in time' explanation #11277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
As of #11252 the error is actually different for hitting the ratelimit |
|
Well, it's worth mentioning somewhere in the guide that this request is rate limited |
|
Hey! Thank you so much for letting me know. I'll change this up to be more in line with the actual behaviour |
|
|
||
| - The `GuildMembers` intent is not specified or enabled in the dev dashboard | ||
| - The internet connection is somewhat bad | ||
| - The amount of members fetched is large (about 50 thousand and upwards) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed?
|
|
||
| This error happens when fetching multiple members via `GuildMemberManager#fetch()` and: | ||
| <Callout> | ||
| Discord recently implemented a rate limit to the `GuildMemberManager#fetch()` call of one fetch per 30 seconds per |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the guide should be written in a fashion that it'll stay true over time. Replace recently with a mention of the date this happened or simply stating it is this way, not that it changed.
| - The `GuildMembers` intent is not specified or enabled in the dev dashboard | ||
| - The internet connection is somewhat bad | ||
| - The amount of members fetched is large (about 50 thousand and upwards) | ||
| - The one fetch per guild per 30 seconds rate limit set by Discord has been exceeded, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise you already changed this on Qjuh's advice, but its also generally not great to be explicit about what the rate limit it. Discord could change it at any time. All this needs to say is that you might be exceeding the rate limit.
Please describe the changes this PR makes and why it should be merged:
Related to issue #11245. Updates the explanation for the 'members didn't arrive in time' error to be in line with the new ratelimit. Minor change to the guide! (also my first PR here -- let me know if I did anything wrong).
Status and versioning classification: