Skip to content

Conversation

@eggs-florentine
Copy link

Please describe the changes this PR makes and why it should be merged:
Related to issue #11245. Updates the explanation for the 'members didn't arrive in time' error to be in line with the new ratelimit. Minor change to the guide! (also my first PR here -- let me know if I did anything wrong).

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Nov 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ready Ready Preview Comment Nov 16, 2025 7:23am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js Skipped Skipped Nov 16, 2025 7:23am

@didinele
Copy link
Member

As of #11252 the error is actually different for hitting the ratelimit

@Jiralite Jiralite changed the title fix(guide): update 'Members didn't arrive in time' explanation (#11245) fix(guide): update 'Members didn't arrive in time' explanation Nov 16, 2025
@Jiralite
Copy link
Member

As of #11252 the error is actually different for hitting the ratelimit

Specifically after #11253, this will throw, so point 2 in #11245 will no longer be relevant in the next version.

@Jiralite Jiralite linked an issue Nov 16, 2025 that may be closed by this pull request
@didinele
Copy link
Member

Well, it's worth mentioning somewhere in the guide that this request is rate limited

@eggs-florentine
Copy link
Author

Hey! Thank you so much for letting me know. I'll change this up to be more in line with the actual behaviour


- The `GuildMembers` intent is not specified or enabled in the dev dashboard
- The internet connection is somewhat bad
- The amount of members fetched is large (about 50 thousand and upwards)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?


This error happens when fetching multiple members via `GuildMemberManager#fetch()` and:
<Callout>
Discord recently implemented a rate limit to the `GuildMemberManager#fetch()` call of one fetch per 30 seconds per
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the guide should be written in a fashion that it'll stay true over time. Replace recently with a mention of the date this happened or simply stating it is this way, not that it changed.

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Nov 30, 2025
- The `GuildMembers` intent is not specified or enabled in the dev dashboard
- The internet connection is somewhat bad
- The amount of members fetched is large (about 50 thousand and upwards)
- The one fetch per guild per 30 seconds rate limit set by Discord has been exceeded,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise you already changed this on Qjuh's advice, but its also generally not great to be explicit about what the rate limit it. Discord could change it at any time. All this needs to say is that you might be exceeding the rate limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

Guide: Update reasons for members didn't arrive in time

5 participants