Add Collection.clone() #1238
Merged
Add Collection.clone() #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not |
|
You can also return new this.constructor(this); ... But to be consistent with existing code, (concat) it is written this way. It was a conscious decision to keep it consistent. |
|
concat has to do that since it iterates in one collection from multiple. |
amishshah
approved these changes
Feb 28, 2017
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
* Add Collection.clone() * More efficient cloning, and concat update * Update Collection.js * Update Collection.js
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
* Add Collection.clone() * More efficient cloning, and concat update * Update Collection.js * Update Collection.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed the other day. I didn't need it for my earlier pr, so I made it a separate pr.