Emoji convenience methods #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
reviewed
Apr 24, 2017
src/structures/Emoji.js
Outdated
| * @param {Role} role The role to add | ||
| * @returns {Promise<Emoji>} | ||
| */ | ||
| addRestrictedRole(role) { |
There was a problem hiding this comment.
this should probably just call this.addRestrictedRoles([role]) for consistancy
|
what about removing restricted roles |
|
I'll see |
devsnek
suggested changes
Apr 25, 2017
src/structures/Emoji.js
Outdated
| for (const role of roles) { | ||
| if (newRoles.has(role.id)) newRoles.delete(role.id); | ||
| } | ||
| return newRoles; |
amishshah
force-pushed
the
master
branch
4 times, most recently
from
260b09e to
5b2ca32
Compare
Requested by Crawl
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
* make branch * stuff * Consistency & remove role(s) * kill me * Doc changes Requested by Crawl * forgot 1
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
* make branch * stuff * Consistency & remove role(s) * kill me * Doc changes Requested by Crawl * forgot 1
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
* make branch * stuff * Consistency & remove role(s) * kill me * Doc changes Requested by Crawl * forgot 1
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds convenience methods (similar to those of RichEmbed) to Emoji, for easier use:
setNameaddRestrictedRoleaddRestrictedRolesremoveRestrictedRoleremoveRestrictedRolesStill a bit indecisive over either stay using array argument or use rest parameters for the
addRestrictedRolesmethod. Let me know if I should use rest parameters.Edit: I can also use both 🤔
Edit 2: If I used both I could also merge the restricted role methods into one method 🤔