Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #1445

Closed
wants to merge 1 commit into from
Closed

Conversation

aemino
Copy link
Contributor

@aemino aemino commented May 1, 2017

Please describe the changes this PR makes and why it should be merged:
Fixes weird spaces in the template and reorganizes options in ascending semver order: patch > minor > major

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl
Copy link
Member

iCrawl commented May 1, 2017

I think the space was meant to be there, considering you check the first one, and if its breaking the second one. They are linked, since you cannot not change the interface without breaking it.

@meew0
Copy link
Contributor

meew0 commented May 1, 2017

@iCrawl is right, the space is intended exactly as described. In PRs where it wasn't deleted (for example #1443) you can see how the checkmark is indented one level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants