-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GuildPreview): implement support for "preview" endpoint #3965
Conversation
preview
endpointThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be more documented
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Could you point the lines of code you believe aren't documented properly? I'll get on it immediately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, just a few things:
I've pushed the new changes, hopefully they meet the requirements of what you described, and the methods (and typings) implemented/changed are good now. |
Maybe we could also add a fetchPreview() method on Guild as I suggested, for ease of use? like how we have GuildMember.ban() and Guild.members.ban(member) |
Sounds good. I'll get on it right now. 👍 |
Please describe the changes this PR makes and why it should be merged:
This PR implements a new feature supporting the
preview
endpoint which is available for public guilds. As mentioned in #3958 — the PR includes the following changes:fetchGuildPreview()
— method on an instance ofClient
, used to fetch a public guild if availableGuildPreview
— a structure for an instance of a Guild that's been fetched through thepreview
endpointIf anything else needs updating, or if there's been a mistake anywhere, please don't hesitate to point it out; I'll try to resolve it immediately. Also, I'd like to apologize for the former PR that I've requested on my main account, I accidentally pushed changes from my original branch.
Status
Semantic versioning classification: