fix(WebsocketShard): pass ignoreACK into sendHeartbeat when Discord asks for one #3993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Currently when Discord sends a "HEARTBEAT" payload (opcode 1) discord.js simply calls
sendHeartbeat
with the appropriate label, without actually telling it to not check if the last heartbeat ever got the ACK.What can end up happening in its current state is:
sendHeartbeat
yet again which will check if the beat sent on step 1 recieved the ACK; if it has, nothing horrible happens, otherwise d.js will respawn the shard under the impression that we're dealing with a zombie connection.Status
Semantic versioning classification: