Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Typings): use Channel instead of *ChannelTypes in ClientEvents #4001

Merged
merged 1 commit into from
Mar 27, 2020
Merged

fix(Typings): use Channel instead of *ChannelTypes in ClientEvents #4001

merged 1 commit into from
Mar 27, 2020

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR removes the references to the removed channel union types.

I seem to somehow have missed those in #3978.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 5e49126 into discordjs:master Mar 27, 2020
@SpaceEEC SpaceEEC deleted the fix/client_event_unions branch March 27, 2020 22:03
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
@maybeanerd maybeanerd mentioned this pull request Apr 21, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpaceEEC @iCrawl