Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(MessageEmbed): document the constructor #4077

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR documents the constructor of MessageEmbed, which somehow was not yet documented.
Resolves #4000?

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@NotSugden
Copy link
Contributor

you previously agreed with this review comment to remove the docstring (on #3894)

@SpaceEEC
Copy link
Member Author

It was since eslint would complain about the "missing"paramter (or rather private pseudo-"overload").

This way eslint is fine, so I think we are clear to go about this.

@iCrawl iCrawl merged commit 4625881 into discordjs:master Apr 16, 2020
@SpaceEEC SpaceEEC deleted the docs/message_embed_ctor branch November 1, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add methods to edit only certain MessageEmbed parts
3 participants