Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Typings): GuildPreview#features and Integration#type #4080

Merged
merged 2 commits into from
Apr 16, 2020
Merged

fix(Typings): GuildPreview#features and Integration#type #4080

merged 2 commits into from
Apr 16, 2020

Conversation

cherryblossom000
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

  • GuildPreview#features is GuildFeatures[] instead of GuildFeatures
  • Integration#type is string instead of number
    This is what the types should be and what they are in the documentation.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl changed the title fix(Typings): fix GuildPreview#features and Integration#type fix(Typings): GuildPreview#features and Integration#type Apr 16, 2020
@iCrawl iCrawl merged commit 72a33cb into discordjs:master Apr 16, 2020
@cherryblossom000 cherryblossom000 deleted the typings branch April 16, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants