Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Message): add crosspostable property #4903

Merged
merged 9 commits into from
Nov 1, 2020
Merged

feat(Message): add crosspostable property #4903

merged 9 commits into from
Nov 1, 2020

Conversation

HarmoGlace
Copy link
Contributor

@HarmoGlace HarmoGlace commented Oct 12, 2020 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

This PR adds the Message#crosspostable property, to know if a message can be crossposted.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@kyranet kyranet requested review from iCrawl and vladfrangu October 12, 2020 19:39
vladfrangu
vladfrangu requested changes Oct 12, 2020
View reviewed changes
src/structures/Message.js Outdated Show resolved Hide resolved
@HarmoGlace HarmoGlace requested a review from vladfrangu October 13, 2020 17:01
advaith1
advaith1 reviewed Oct 14, 2020
View reviewed changes
src/structures/Message.js Outdated Show resolved Hide resolved
@HarmoGlace @advaith1
Removed useless flag checks
7b13bc4 
Co-authored-by: Advaith <advaithj1@gmail.com>
TeeSeal
TeeSeal reviewed Oct 21, 2020
View reviewed changes
src/structures/Message.js Outdated Show resolved Hide resolved
HarmoGlace and others added 2 commits October 21, 2020 12:55
@HarmoGlace @TeeSeal
Update src/structures/Message.js
cdc02e2 
Co-authored-by: Alex Hîncu <teesealz@gmail.com>
@HarmoGlace
Made eslint happy
44bedca
@iCrawl iCrawl merged commit b8fd3f6 into discordjs:master Nov 1, 2020
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@HarmoGlace HarmoGlace deleted the crosspostable branch April 10, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden left review comments

@TeeSeal TeeSeal TeeSeal left review comments

@advaith1 advaith1 advaith1 left review comments

@wasdennnoch wasdennnoch wasdennnoch left review comments

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@HarmoGlace @wasdennnoch @advaith1 @TeeSeal @vladfrangu @iCrawl @kyranet @NotSugden