-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Application): application flags #5147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should probably be info/warn tags on the description of Client#generateInvite()
and the Client#application
property saying they can only be used/present if the client is logged in
I went with an error instead of adding it to the docs since that's what most methods do |
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
|
Yeah, and I don't know if they should be documented - I'll ask later. But, flag wise, the main ones I know off are related to the intents switches |
bitfield flags: MANAGED_EMOJI = 4, |
where are those taken from? 👀 |
the client |
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Please describe the changes this PR makes and why it should be merged:
Adds support for the new
application.flags
property as of discord/discord-api-docs#2295. Since this is only sent withREADY
and not withGet Current Application
, some parts of the lib needs a bit of restructuring:client.application
–null
when instantiating, a partial application as soon asREADY
gets emittedapplication.flags
(obviously)application.partial
client.fetchApplication()
->client.application.fetch()
client.generateInvite()
:Promise<string>
->string
(sinceid
is sent withREADY
too)Status
Semantic versioning classification: