-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WebhookClient): allow creation of clients via URLs #6192
Conversation
@vladfrangu fixed! Thanks for reminding. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the constructor typings need updating still
@NotSugden @Jiralite done! Your suggestions have been committed. Thanks a lot.
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, I am actually in need of this too :D
Thanks for the addition @J-Human |
Please describe the changes this PR makes and why it should be merged:
This allows
WebhookClient
's to be made with URLs, without the need of removing it or doing any type of parsing. This is useful for pass-through services like Webhook senders, etc., allowing a more convenient time for developers who don't want to use IDs and tokens. Example:This PR also updates:
It now mandates initializing Webhook clients should have one object parameter, that can contain either ID + token or just a URL (this isn't validated so all 3 are optional).
Fixes #6164
Status and versioning classification: