chore(Typings): fix WebhookEditMessageOptions not having attachments #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milo123459
changed the title
SpaceEEC
reviewed
Aug 14, 2021
There was a problem hiding this comment.
Could you also add that to the relevant jsdoc? 👀
discord.js/src/structures/Webhook.js
Line 100 in 71fdf6f
|
@SpaceEEC do I have to edit MessageOptions in the jsdoc? EDIT: I did it for TextBasedChannel's MessageOptions and WebhookEditMessageOptions |
Jiralite
reviewed
Aug 15, 2021
kyranet
approved these changes
Aug 15, 2021
vladfrangu
approved these changes
Aug 16, 2021
iCrawl
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes some issues in the Typings (basically like my previous PR #6162)
attachmentswasn't typed inMessageOptions, so I added that and update the Pick when definingWebhookEditMessageOptionsto add attachments to the typings and to ensure this doesn't bugStatus and versioning classification:
Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating